Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore img tag when using linkifier #3173

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

tpmai22
Copy link
Contributor

@tpmai22 tpmai22 commented Mar 11, 2022

Issue This PR Addresses

Fixed #2941

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Ignore img tag when linkify

Steps to test the PR

At the root directory remove redis-data

rm -r redis-data

Rebuild images, pnpm services:start and wait for redis to cache the feeds

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Mar 11, 2022

@tpmai22 tpmai22 self-assigned this Mar 11, 2022
@tpmai22 tpmai22 added area: front-end 5 min fix Fixable in 5 minutes or less area: performance Issues related to our performance review: easy labels Mar 11, 2022
@tpmai22 tpmai22 added this to the 2.8 Release milestone Mar 11, 2022
humphd
humphd previously approved these changes Mar 11, 2022
@tpmai22 tpmai22 requested a review from humphd March 11, 2022 17:39
@DukeManh DukeManh merged commit b362fad into Seneca-CDOT:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min fix Fixable in 5 minutes or less area: front-end area: performance Issues related to our performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude img tags from linkifyHtml
5 participants